Feature/filter setcode tx #8167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ak88
requested review from
marcindsobczak,
LukaszRozmej,
flcl42,
MarekM25 and
smartprogrammer93
LukaszRozmej
approved these changes
Feb 10, 2025
Comment on lines
20
to
38
| protected override IComparer<Transaction> GetGroupComparer(IComparer<Transaction> comparer) | ||
| { | ||
| throw new NotImplementedException(); | ||
| } | ||
|
|
||
| protected override UInt256 GetKey(Transaction value) | ||
| { | ||
| throw new NotImplementedException(); | ||
| } | ||
|
|
||
| protected override IComparer<Transaction> GetUniqueComparer(IComparer<Transaction> comparer) | ||
| { | ||
| throw new NotImplementedException(); | ||
| } | ||
|
|
||
| protected override AddressAsKey MapToGroup(Transaction value) | ||
| { | ||
| throw new NotImplementedException(); | ||
| } |
There was a problem hiding this comment.
Is this ok to leave like that? Aren’t those required?
There was a problem hiding this comment.
I thought i had deleted this. Will remove it.
There was a problem hiding this comment.
I think it is abstract, I thought those were kind of mandatory?
There was a problem hiding this comment.
I meant the whole class. I had a more complex solution before, until I figured the current solution would be simpler. So this is no longer used at all.
src/Nethermind/Nethermind.TxPool/Filters/OnlyOneTxPerDelegatedAccountFilter.cs
Outdated
Show resolved
Hide resolved
…AccountFilter.cs Co-authored-by: Lukasz Rozmej <[email protected]>
…mindEth/nethermind into feature/filter-setcode-tx
marcindsobczak
approved these changes
Feb 10, 2025
src/Nethermind/Nethermind.TxPool/Filters/OnlyOneTxPerDelegatedAccountFilter.cs
Outdated
Show resolved
Hide resolved
marcindsobczak
approved these changes
Feb 10, 2025
src/Nethermind/Nethermind.TxPool.Test/OnlyOneTxPerDelegatedAccountFilterTest.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.TxPool/Filters/OnlyOneTxPerDelegatedAccountFilter.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.TxPool.Test/OnlyOneTxPerDelegatedAccountFilterTest.cs
Outdated
Show resolved
Hide resolved
kamilchodola
pushed a commit
that referenced
this pull request
Feb 12, 2025
Co-authored-by: Lukasz Rozmej <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for
OnlyOneTxPerDelegatedAccountFilterto align with ethereum/go-ethereum#31073Filter now also restricts
SetCodetx that has any delegation authority with a pending tx."Only one tx for delegated account" rule, is simplified to only accept a tx from delegated account if the nonce matches current account state.
Things to note: